.net - How to optimize my if else code c# -


i have code below:

tryupdatemodel(model);             if (modelstate.isvalid && model.fullnameischecked == true && model.lookingfor == null)             {                 model.contactlist = contactrepository.getall(filter: x => x.userid == user.id);                 model.contactlist.sort((x, y) => string.compare(x.fullname, y.fullname));             }             else if (modelstate.isvalid && model.fullnameischecked == false && model.lookingfor == null)             {                 model.contactlist = contactrepository.getall(filter: x => x.userid == user.id);                 model.contactlist.sort((x, y) => string.compare(x.email, y.email));             }             else if (modelstate.isvalid && model.lookingfor != null && model.fullnameischecked == true)             {                 model.contactlist = contactrepository.getall(filter: x => x.userid == user.id);                 model.contactlist = contactrepository.getall(filter: x => x.fullname.contains(model.lookingfor));                 model.contactlist.orderby(f => f.fullname);             }             else if (modelstate.isvalid && model.lookingfor != null && model.fullnameischecked == false)             {                 model.contactlist = contactrepository.getall(filter: x => x.userid == user.id);                 model.contactlist = contactrepository.getall(filter: x => x.email.contains(model.lookingfor));                 model.contactlist.orderby(e => e.email);             }             else             {                 model.contactlist = contactrepository.getall(filter: x => x.userid == user.id);             }

i'm using .net mvc 5 razor engine, , code above make sorting operations. can optimize if else part of code? thing on mind use switch - case operator similarly. in advance

  • i cant see use in code checking state modelstate

  • no need compare bool in if condition, ie

    if(true)

    is same as

    if(bool variable=true)

  • use string.isnullorempty check null

     tryupdatemodel(model);    model.contactlist = contactrepository.getall(filter: x => x.userid == user.id);          if(  string.isnullorempty(model.lookingfor))         {             if(model.fullnameischecked)             {                 model.contactlist.sort((x, y) => string.compare(x.fullname, y.fullname));             }             else             {                 model.contactlist.sort((x, y) => string.compare(x.email, y.email));             }         }         else         {             if(model.fullnameischecked)             {                model.contactlist = contactrepository.getall(filter: x => x.fullname.contains(model.lookingfor));                model.contactlist.orderby(f => f.fullname);             }             else             {                model.contactlist = contactrepository.getall(filter: x => x.userid == user.id);                model.contactlist = contactrepository.getall(filter: x => x.email.contains(model.lookingfor));             }         }

Comments

Post a Comment

Popular posts from this blog

toolbar - How to add link to user registration inside toobar in admin joomla 3 custom component -

im trying write component admin side , need add user creation. dont want duplicate existing codes add link. know how add task not simple link toolbar. thx help. if wanting button opens new user screen can try in component: $bar = jtoolbar::getinstance('toolbar'); $bar->appendbutton('link', 'users', 'new user','index.php?option=com_users&task=user.add'); you need add view.html.php file wherever you're creating toolbar. is need?
Read more

linux - disk space limitation when creating war file -

i have 1 gb disk space limitation hosting app , have used 700mb of it. however want create war file directory big (around 600mb) using command : jar -cvf root.war folderpath that's why encounter quota limitation , can't following. i'm looking way delete folder content when it's applying archive conserve disk space take note can't install zip tool in ssh shell ~ the code works on test directories, test first anyway, deletes files. it's not efficient. assumptions: 300mb free space, in destructively compress 600mb folderpath directory. none of files big -- if file in folderpath 300mb or larger, fail. notes: if ' $out ' file exists, nothing. first find pipes file list while , if ' $out ' doesn't exist in loop, create it, don't update -- if does exist, update it. each pass adds 1 more file, deletes unless file directory. after loop finishes delete empty directories too. unset u ; in=folderpath ; out=roo...
Read more